Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bind): allow serialization of Some(_) and None values (as the inner value and NULL respectively) #120

Merged
merged 3 commits into from
Aug 7, 2024
Merged

fix(bind): allow serialization of Some(_) and None values (as the inner value and NULL respectively) #120

merged 3 commits into from
Aug 7, 2024

Conversation

v3xro
Copy link
Contributor

@v3xro v3xro commented Jul 30, 2024

Fixes #119

loyd
loyd reviewed Aug 4, 2024
View reviewed changes
src/sql/mod.rs Show resolved Hide resolved
loyd
loyd requested changes Aug 4, 2024
View reviewed changes
src/sql/ser.rs Outdated Show resolved Hide resolved
@v3xro v3xro requested a review from loyd August 5, 2024 19:36
@loyd loyd merged commit 47e49b4 into ClickHouse:master Aug 7, 2024
6 checks passed
@loyd
Copy link
Collaborator

loyd commented Aug 7, 2024

Merged. Thanks for your contribution!

loyd added a commit that referenced this pull request Aug 7, 2024
@loyd
docs(CHANGELOG): note about #119 and #120
a8e3206
@v3xro v3xro deleted the fix/bind-optional branch September 6, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slvrtrn slvrtrn slvrtrn left review comments

@loyd loyd loyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to serialize Option<_> bind
3 participants
@v3xro @loyd @slvrtrn